Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for ZIP: MoonBaZe-0001 aka BigInt #5

Merged
merged 18 commits into from
Aug 1, 2023
Merged

Add support for ZIP: MoonBaZe-0001 aka BigInt #5

merged 18 commits into from
Aug 1, 2023

Conversation

KingGorrin
Copy link
Collaborator

@KingGorrin KingGorrin commented Jun 14, 2023

This PR contains the Zenon Sdk for .NET implementation of the ZIP: MoonBaZe-0001 proposal that has been implemented on the go-zenon repository following PR#20.

All big.Int RPC responses are now parsed as strings and converted to BigInteger.

@KingGorrin KingGorrin changed the title BigInteger support BigInt support Jun 14, 2023
@KingGorrin KingGorrin changed the title BigInt support Add support for BigInt (ZIP: MoonBaZe-0001) Jun 14, 2023
@KingGorrin KingGorrin changed the title Add support for BigInt (ZIP: MoonBaZe-0001) Add support for ZIP: MoonBaZe-0001 aka BigInt Jun 14, 2023
@codecov
Copy link

codecov bot commented Jul 12, 2023

Codecov Report

Patch coverage: 63.60% and project coverage change: -0.11% ⚠️

Comparison is base (89be6a8) 63.05% compared to head (911fae6) 62.95%.

❗ Current head 911fae6 differs from pull request most recent head 1f3bf9e. Consider uploading reports for the commit 1f3bf9e to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main       #5      +/-   ##
==========================================
- Coverage   63.05%   62.95%   -0.11%     
==========================================
  Files         197      199       +2     
  Lines        5617     5680      +63     
==========================================
+ Hits         3542     3576      +34     
- Misses       2075     2104      +29     
Flag Coverage Δ
unittests 62.95% <63.60%> (-0.11%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
src/Zenon/Model/Embedded/Project.cs 20.20% <0.00%> (ø)
src/Zenon/Model/NoM/AccountInfo.cs 44.44% <0.00%> (+4.44%) ⬆️
src/Zenon/Utils/BlockUtils.cs 0.00% <0.00%> (ø)
src/Zenon/Utils/AmountUtils.cs 10.34% <12.00%> (-64.66%) ⬇️
src/Zenon/Model/Embedded/DelegationInfo.cs 29.16% <25.00%> (-4.17%) ⬇️
src/Zenon/Model/Embedded/FusionEntry.cs 25.00% <25.00%> (ø)
src/Zenon/Model/Embedded/FusionEntryList.cs 40.00% <25.00%> (ø)
src/Zenon/Model/Embedded/PlasmaInfo.cs 26.08% <25.00%> (ø)
src/Zenon/Model/Embedded/SwapAssetEntry.cs 29.16% <25.00%> (ø)
src/Zenon/Model/Embedded/StakeList.cs 37.93% <28.57%> (ø)
... and 50 more

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@KingGorrin KingGorrin added the enhancement New feature or request label Jul 20, 2023
@KingGorrin KingGorrin self-assigned this Jul 20, 2023
@KingGorrin KingGorrin merged commit 36795dd into main Aug 1, 2023
@KingGorrin KingGorrin deleted the bigint branch August 1, 2023 07:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant